rdmtc / node-red-contrib-sun-position

This is a ultimate Node-Red Timer, Sun, Moon and Blind flow control.
Apache License 2.0
105 stars 24 forks source link

"Valid Months" issue in Inject Enhanced node #513

Open DeltaNu1142 opened 1 year ago

DeltaNu1142 commented 1 year ago

I have an Inject Enhanced node which I have set to be valid during the months of May through November. However, it continues to send events through January. The issue is best illustrated in a post I started over at the Home Assistant Community, direct link here.

carsten-re commented 1 year ago

I'm facing the same issue. I think the documentation is not very good described. I'd to also define the valid time range. So my settings looks like this:

grafik

The inject node now says, that today is not in valid range: grafik

zinen commented 1 year ago

I have the same issue with the time-inject node. My temporary solution to this is to place a within-time-switch behind this node with the same settings. The within-time-switch node has the same settings but seems to work properly.

weha commented 1 year ago

Issue is still occurring and it seems a bit stale here but there is an alternative though: https://flows.nodered.org/node/node-red-contrib-cron-plus

eugenet8k commented 3 months ago

I got the same issue, it looks like just a code bug, if all days of the week are checked, then the "Valid Months" value is ignored, but if at least one day is not checked, then it will be respected. This wasn't like this always, a regression appeared after some version update. Sadly...

I want the node only to work at Winter, but it still picks today's Apr 4th

wrong-today-in-Apr

But if I uncheck Sunday, it will work and target the first days of the following November

correct-last-day-of-winter
eugenet8k commented 3 months ago

@weha thanks for the hint, I was able to recreate this node using node-red-contrib-cron-plus