rdnelson / Libra

An 8086 emulator with a focus on educational features.
Other
13 stars 4 forks source link

Toolbar icons missing #114

Closed jrgreen7 closed 11 years ago

jrgreen7 commented 11 years ago

My toolbar has buttons, but they are invisible...

rdnelson commented 11 years ago

This sounds like a glitch with the deployment steps, they were written yesterday, so I'll investigate.

rdnelson commented 11 years ago

Fix has been submitted, just need further testing on a different dev box to ensure dynamic builds weren't broken. @DarrenStahl could you pull the beta-1.2-vs2010-redist branch and ensure that you can still build the 'release' and 'debug' configurations. 'release_static' shouldn't work for you though.

DarrenStahl commented 11 years ago

@rdnelson dynamic builds confirmed to work on both my dev boxes.

rdnelson commented 11 years ago

Great, I'm going to push a static debug version in a few minutes and then close the issue. Thanks for the confirmation.

rdnelson commented 11 years ago

Ok, the new commit is up. @DarrenStahl any chance for another check?

DarrenStahl commented 11 years ago

All is good still. Want me to build Qt statically to test the static builds on a different dev box as well?

rdnelson commented 11 years ago

I've covered testing the two static builds. When I built Qt in static mode I found that it messes up the dynamic libraries, preventing me from compiling them again. Otherwise I would have tested those myself. Thanks for the verification, I'm going to merge the branch and resolve this Issue now.