rdnfn / beobench

A toolkit providing easy and unified access to building control environments for reinforcement learning (RL).
https://beobench.readthedocs.io
MIT License
39 stars 4 forks source link

step_size not passed on to energym by integration #63

Open rdnfn opened 2 years ago

rdnfn commented 2 years ago

Problem

There appears to be a mismatch between the user-defined step size and the actual step size of the simulation. The plot below shows the solar radiation, and indicates that a day is about 480 steps (step_size 3min), as opposed to the 96 steps that the configured step_size of 15min would mean.

Screenshot 2022-04-11 at 17 37 15

Potential Solution

As far as I can tell the step_size parameter is not actually passed on to the Energym env making command, thus it defaults to another step_size. Creating the relevant logic should be sufficient to fix this.