search

rdo-puppet-modules / puppet-firewalld

Puppet firewalld module
GNU General Public License v2.0
11 stars 18 forks source link

Errors in configuration files when using createresources #26

Open norlaminis opened 9 years ago

norlaminis commented 9 years ago

When using hiera, the zone.xml files become corrupt, eg, "" is displayed in the XML zone file. which causes the zone to fail to load. As when its left as Undef in puppet when there is no parameter match, undef is still a value, blank but a value.

In the file zoneprovider.rb I have included "next if source.empty?" line for each type Source, Interfaces, forward_ports, icmp and the like Which is a quick workaround for me. But wondering if your intending on setting the module up for use with Hiera in the future ?

asasfu commented 9 years ago

norlaminis, can you give my fork a test against your issue here? It may fix this issue as I updated the XML format output which caused things to break if you created your zone with this module but later ran firewall-cmd against the zone. https://github.com/sfu-rcg/puppet-firewalld