search

rdoeffinger / Dictionary

"QuickDic" offline Dictionary App for Android. Provided downloadable dictionaries are based on Wiktionaries but can also be created from other sources (see DictionaryPC). Remember to use --recursive when cloning! Fork of project that used to be hosted at code.google.com/p/quickdic-dictionary.
Apache License 2.0
327 stars 69 forks source link

Pay attention to accents when searching #131

Closed xxxxme closed 3 years ago

xxxxme commented 4 years ago

Please pay attention to accented characters when searching. In the Spanish <-> English dictionary, when I search for a word containing an accented character (ex: cómo), if there's another entry before it without the accent (como), I'll get that one instead. In the example I chose, the entry without the accent is 10.5 screens long on my device, which I have to scroll past to see the entry I want. With other words I'll get an entry telling me the unaccented version is a misspelling, which causes confusion. Android 9 (LOS)

rdoeffinger commented 4 years ago

I thought I had fixed that (admittedly, the issue was with Russian, so might have been slightly different), need to check why it does not work. Though for the "10 screens long" issue there is the "next word" button/menu entry at least ;)

rdoeffinger commented 3 years ago

As you can see I pushed a fix for it, but I am a little worried if it's really working perfectly. Would you or anyone else be willing and able to test it? I can provide a apk file either here or push a beta version to the Play store if any of those would work for you. Can also do a debug version that can be installed in parallel to the normal one (but you might get confused which is which, since they'll have the some icon).

rdoeffinger commented 3 years ago

Also, it's kind of a partial fix, which could be improved but I am not sure what the best way is. For example, if you search for cómo it will find it, but if you have written only "cóm" (which is not a word in the dictionary) it will search for the best match for "com" as before and ignore the accent. And this is a bit hard to fix as words with and without accent are mixed in the dictionary order. Easier to fix, but not sure it's worth it/a good idea, is if you have a word with multiple accents but you get one wrong, it will fall back to a search completely ignoring accents. In other words, this only fixes the specific case where you spelled the word fully and correctly.

rdoeffinger commented 3 years ago

Included in latest release.