search

rdoeffinger / Dictionary

"QuickDic" offline Dictionary App for Android. Provided downloadable dictionaries are based on Wiktionaries but can also be created from other sources (see DictionaryPC). Remember to use --recursive when cloning! Fork of project that used to be hosted at code.google.com/p/quickdic-dictionary.
Apache License 2.0
327 stars 69 forks source link

Fixed dark theme css #133

Closed shaked6540 closed 4 years ago

shaked6540 commented 4 years ago

The dark theme did not apply correctly everywhere because of broken css, I also added better dark colors (instead of black/white, I choose dark gray for the background and light gray for the text, links will be shown in a bluish gray color)

This fixes #43

Heres an example of how it will look:

rdoeffinger commented 4 years ago

The dark theme colours are defined here: https://github.com/rdoeffinger/Dictionary/blob/master/res/values/styles.xml With your patch the webview would be using a different colour scheme from the rest of the app. I don't think that's a good idea.

shaked6540 commented 4 years ago

No matter what theme you use, light or dark, the dictionary entry page looks like this

When using dark mode in a dark room this really hurts the eyes. In my version, it would make pages darker when using dark theme and they will remain the same when in light theme. If they colors are the problem then I can change them to whatever you want, but I think the colors are fine

And, just to be clear, this change only applies to an entry in the dictionary, not to anywhere else in the app

This is how it looks like in app when using dark theme with my version: