Symfony 3.0 comptibility

rdohms / dms-filter-bundle

Provides a FilterService for Symfony to allow users to implement input filtering in entities using Annotations

MIT License

78 stars 25 forks source link

Symfony 3.0 comptibility #27

Closed rdohms closed 8 years ago

rdohms commented 8 years ago

In order to make the bundle compatible with 3.0 we need to break BC for versions below 2.8 of Symfony.

So v2 will remain symfony 2.3+ compatible and the new v3 release will be 2.8 | 3.* compatible.

msvrtan commented 8 years ago

There are few more changes needed for Symfony 3.0 compatibility:

[x] DMS\Bundle\FilterBundle\Form\Type\FormTypeFilterExtension: The FormTypeExtensionInterface::setDefaultOptions() method is deprecated since version 2.7 and will be removed in 3.0. Use configureOptions() instead. This method will be added to the FormTypeExtensionInterface with Symfony 3.0
[x] The alias option of the form.type_extension tag of service "dms.filter.type_extension" is deprecated since version 2.8 and will be removed in 3.0. Use the extended_type option instead

If you are interested I can fix them and send a PR.

rdohms commented 8 years ago

@msvrtan that would be awesome

msvrtan commented 8 years ago

@rdohms just sent the PR #28

ttibensky commented 8 years ago

Tagged form type extension must have the extended type configured using the extended_type/extended-type attribute, none was configured for the "dms.filter.type_extension" service.

Do you have a version which is fully compatible with symfony3 or should I fix it and create a PR?

ttibensky commented 8 years ago

actually, just create a new tag so we don't need to have your library open using dev-master

rdohms commented 8 years ago

v3.0 has been released.