search

rdohms / meetup-api-client

Guzzle powered Meetup.com API Client
MIT License
76 stars 24 forks source link

Fixing issue #53: preventing a division by zero error #55

Closed rdohms closed 6 years ago

rdohms commented 6 years ago

In rare occasions you hit a "division by zero" error because you no longer have any requests remaing and there's no check for the value of the divided number. In this scenario the plugin should sleep until the next rate limit reset.

This PR patches up @dragonbe's patch to force a longer sleep instead of no sleep. Awaiting discussion in #53 to confirm desired output.

rdohms commented 6 years ago

Travis is really not co-operating, their own solutions do not seem to solve the test issue... damn this PHP 5.3

DragonBe commented 6 years ago

We have moved away from travis-ci and use circle-ci or continuousphp for our project tests.

DragonBe commented 6 years ago

Thank you for this update 👏