search

rdp / ffmpeg-windows-build-helpers

Helper script for cross compiling some media tools for windows, like customizable ffmpeg.exe (with or without non-free components, etc), and some other bonuses like mplayer, mp4box, mxf, etc.
GNU General Public License v3.0
1.07k stars 409 forks source link

Fix x265 3.6 x86 asm optimization #738

Closed AnimMouse closed 1 month ago

AnimMouse commented 1 month ago

Fix x265 3.6 x86 asm optimization by adding a patch that restore this line if("${SYSPROC}" STREQUAL "" OR X86MATCH GREATER "-1") in CMakeLists.txt. Fixes #736, fixes #681, fixes #599, fixes https://github.com/AnimMouse/ffmpeg-stable-autobuild/issues/131.

Master:

ffmpeg version git-2024-05-04-38f67a3-ffmpeg-windows-build-helpers Copyright (c) 2000-2024 the FFmpeg developers
x265 [info]: HEVC encoder version 3.6+1-2f95fe7c8
x265 [info]: build info [Windows][GCC 10.2.0][64 bit] 8bit+10bit+12bit
x265 [info]: using cpu capabilities: MMX2 SSE2Fast LZCNT SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2

Release 7.0:

ffmpeg version n7.0-ffmpeg-windows-build-helpers Copyright (c) 2000-2024 the FFmpeg developers
x265 [info]: HEVC encoder version 3.6+1-2f95fe7c8
x265 [info]: build info [Windows][GCC 10.2.0][64 bit] 8bit+10bit+12bit
x265 [info]: using cpu capabilities: MMX2 SSE2Fast LZCNT SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2
rdp commented 1 month ago

thanks

rdp commented 1 month ago

A bug report upstream might be nice here too, or if not I might get to it someday :)

AnimMouse commented 1 month ago

@rdp As of ba57a46 BtbN/FFmpeg-Builds started using x265 version 3.6, and it did not cause any problems in their build script, I wonder maybe if this problem is related to this build script, or somewhere around the compilers that this build script uses.

rdp commented 1 month ago

is that older so still working?

On Tue, May 21, 2024 at 10:32 PM Anim Mouse @.***> wrote:

@rdp https://github.com/rdp As of ba57a46 https://github.com/BtbN/FFmpeg-Builds/commit/ba57a4697f1cb9c3eab43fc814eddc68053f5b53#diff-21a75787ac26a51e4d17cfcdc3bf1013335b990b9f2b3bc2a6ad833b93c66cd8 BtbN/FFmpeg-Builds started using x265 version 3.6, and it did not cause any problems in their build script, I wonder maybe if this problem is related to this build script, or somewhere around the compilers that this build script uses.

— Reply to this email directly, view it on GitHub https://github.com/rdp/ffmpeg-windows-build-helpers/pull/738#issuecomment-2123846355, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADBUBKQGWBMHM4NIU7TN3ZDQNVFAVCNFSM6AAAAABHG2A722VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTHA2DMMZVGU . You are receiving this because you were mentioned.Message ID: @.***>

AnimMouse commented 3 weeks ago

@rdp No, they are using the new one, the one that uses if(X86MATCH GREATER "-1") in the CMakeLists.txt, and their x265 build script is working properly with ASM.