search

rdp / google_hash

wrapper for google's hash functions, for ruby
BSD 3-Clause "New" or "Revised" License
92 stars 16 forks source link

Method mark_hash_map_values() invokes Ruby code; which can crash the Ruby process #39

Open charlez opened 8 years ago

charlez commented 8 years ago

Running multi-threaded Ruby applications that make use of google_hash occasionally crash the Ruby process during garbage collection. Method mark_hash_map_values() uses erb (and hence invokes Ruby), and should not do so:

Please refer to: https://bugs.ruby-lang.org/issues/11799 In particular, note Koichi Sasada's comments in #5 and #6.

rdp commented 8 years ago

Wow good find. I have attempted to address it in v 0.9.0 care to test it for me?

On Thu, Dec 10, 2015 at 11:05 AM, charlez notifications@github.com wrote:

Running multi-threaded Ruby applications that make use of google_hash occasionally crash the Ruby process during garbage collection. Method mark_hash_map_values() uses erb (and hence invokes Ruby), and should not do so:

Please refer to: https://bugs.ruby-lang.org/issues/11799 In particular, note Koichi Sasada's comments in #5 https://github.com/rdp/google_hash/issues/5 and #6 https://github.com/rdp/google_hash/issues/6.

— Reply to this email directly or view it on GitHub https://github.com/rdp/google_hash/issues/39.

charlez commented 8 years ago

Please let me know when v 0.9.0 exists; I'll download it, test it, and report the results. Best if this can happen reasonably soon because my test system resources might soon become unavailable.