rdp / os

The OS gem allows for some easy telling if you’re on windows or not. OS.windows? as well as some other helper utilities
MIT License
145 stars 33 forks source link

Provide tag for version 1.0.1 #36

Closed koppor closed 4 years ago

koppor commented 4 years ago

Version 1.0.1 is released: https://rubygems.org/gems/os

I don't see a 1.0.1 tag in this repository. Is this intended?

Maybe, you could use KeepAChangelog instead of the custom log format (https://github.com/rdp/os/blob/master/ChangeLog). πŸ˜‡

rdp commented 4 years ago

Hmm making a tag for every release seems like overkill for such a small project hmm :)

On Sat, Sep 21, 2019 at 7:05 AM Oliver Kopp notifications@github.com wrote:

Version 1.0.1 is released: https://rubygems.org/gems/os

I don't see a 1.0.1 tag in this repository. Is this intended?

Maybe, you could use KeepAChangelog https://keepachangelog.com/en/1.0.0/ instead of the custom log format ( https://github.com/rdp/os/blob/master/ChangeLog). πŸ˜‡

β€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rdp/os/issues/36?email_source=notifications&email_token=AAADBUBPEIYRZ2FTABA53EDQKYL3HA5CNFSM4IY6FUR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HM2K4LA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAADBUCU4OCKMD72FTHTWC3QKYL3HANCNFSM4IY6FURQ .

koppor commented 4 years ago

I think all projects deserve proper versioning πŸ˜‡. If something goes wrong while using, it is more easy to report issues (or even track down), if the concrete code for a concrete version is known.

shepmaster commented 4 years ago

for such a small project

Your project is used by the googleauth gem, which seems likely to be used by a fair number of projects.

rdp commented 4 years ago

I think 1.1 is tagged right...FWIW :)

On Tue, Mar 31, 2020 at 9:29 AM Jake Goulding notifications@github.com wrote:

for such a small project

Your project is used by the googleauth https://rubygems.org/gems/googleauth gem, which seems likely to be used by a fair number of projects.

β€” You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rdp/os/issues/36#issuecomment-606699316, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADBUG35XTCFOT7LGJKIO3RKID57ANCNFSM4IY6FURQ .

koppor commented 4 years ago

Thank you!

In case you are afraid of the effort, you can use https://www.npmjs.com/package/github-release-from-changelog. OK, then the issue is to switch from a custom changelog format (https://github.com/rdp/os/blob/master/ChangeLog) to KeepAChangelog. ^^

shepmaster commented 4 years ago

I think 1.1 is tagged right

It might be, but I stumbled on this issue when attempting to figure out what had changed from 1.0.1 to 1.1. (This was the best I could figure)