rdp / os

The OS gem allows for some easy telling if you’re on windows or not. OS.windows? as well as some other helper utilities
MIT License
145 stars 33 forks source link

Files inside os gem are world writable #44

Open vinayakvakkund opened 4 years ago

vinayakvakkund commented 4 years ago

I found that the files inside os gem are world writable. Is it possible to change the permissions?

image

rdp commented 3 years ago

I am unable to repro, do you still?

pboling commented 2 years ago

It is possible to change the permissions in git, but on a fresh checkout I too am unable to reproduce. I think this report was caused by a bug or artifact of vagrant.

sethboyles commented 1 year ago

@pboling We don't see world writable upon checking out this repo, but when install the gem we do:

~/.gem/ruby/3.2.2/gems/os-1.1.4$ ls
autotest  ChangeLog  Gemfile  Gemfile.lock  lib  LICENSE  os.gemspec  Rakefile  README.md  spec  VERSION
~/.gem/ruby/3.2.2/gems/os-1.1.4$ ls -al
total 68
drwxr-xr-x   5 pivotal pivotal  4096 Jul 24 06:23 .
drwxrwxr-x 208 pivotal pivotal 12288 Jul 24 06:24 ..
-rw-rw-rw-   1 pivotal pivotal   501 Jul 24 06:23 .autotest
drwxrwxr-x   2 pivotal pivotal  4096 Jul 24 06:23 autotest
-rw-r--r--   1 pivotal pivotal   581 Jul 24 06:23 ChangeLog
-rw-rw-rw-   1 pivotal pivotal    60 Jul 24 06:23 .document
-rw-rw-rw-   1 pivotal pivotal    38 Jul 24 06:23 Gemfile
-rw-rw-rw-   1 pivotal pivotal   313 Jul 24 06:23 Gemfile.lock
drwxrwxr-x   2 pivotal pivotal  4096 Jul 24 06:23 lib
-rw-rw-rw-   1 pivotal pivotal  1082 Jul 24 06:23 LICENSE
-rw-r--r--   1 pivotal pivotal  2023 Jul 24 06:23 os.gemspec
-rw-r--r--   1 pivotal pivotal  1346 Jul 24 06:23 Rakefile
-rw-r--r--   1 pivotal pivotal  2596 Jul 24 06:23 README.md
drwxrwxr-x   2 pivotal pivotal  4096 Jul 24 06:23 spec
-rw-r--r--   1 pivotal pivotal     6 Jul 24 06:23 VERSION
~/.gem/ruby/3.2.2/gems/os-1.1.4$ ls -al spec/
total 28
drwxrwxr-x 2 pivotal pivotal 4096 Jul 24 06:23 .
drwxr-xr-x 5 pivotal pivotal 4096 Jul 24 06:23 ..
-rw-rw-rw- 1 pivotal pivotal 1202 Jul 24 06:23 linux_spec.rb
-rw-rw-rw- 1 pivotal pivotal 5425 Jul 24 06:23 os_spec.rb
-rw-rw-rw- 1 pivotal pivotal  806 Jul 24 06:23 osx_spec.rb
-rw-rw-rw- 1 pivotal pivotal  261 Jul 24 06:23 spec_helper.rb
pboling commented 1 year ago

Interesting. I will try to repro that way. Thanks for the follow up.