rdp / os

The OS gem allows for some easy telling if you’re on windows or not. OS.windows? as well as some other helper utilities
MIT License
145 stars 33 forks source link

missing git tag 1.1.4 #66

Closed anthraxx closed 2 years ago

anthraxx commented 2 years ago

I'd like to ask to get tag for gem release 1.1.4 tagged and released. Not sure which commit, maybe f1f4c332048308d14160e33cc97a4214a368c9ee?

Reasoning: It's not just important that it is easy to map tags to actual releases in the source tree. But for distro packaging we actually require to have a matching git tag for every release as the rule of thumb is to build from the version control state in order to aid transparency and confidence in public reviewed code etc.

Problem: As of the above, the missing tag for 1.1.4 create the issue for me that i can't package ruby-os for our Distro currently.

Related to #36

rdp commented 2 years ago

attempted it

On Fri, Aug 19, 2022 at 10:51 AM Levente Polyak @.***> wrote:

I'd like to ask to get tag for gem release 1.1.4 tagged and released. Not sure which commit, maybe f1f4c33 https://github.com/rdp/os/commit/f1f4c332048308d14160e33cc97a4214a368c9ee ?

Reasoning: It's not just important that it is easy to map tags to actual releases in the source tree. But for distro packaging we actually require to have a matching git tag for every release as the rule of thumb is to build from the version control state in order to aid transparency and confidence in public reviewed code etc.

Problem: As of the above, the missing tag for 1.1.4 create the issue for me that i can't package ruby-os for our Distro currently.

Related to #36 https://github.com/rdp/os/issues/36

— Reply to this email directly, view it on GitHub https://github.com/rdp/os/issues/66, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADBUEGS63CB3JHZY54SEDVZ63PHANCNFSM57BK6LIA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

anthraxx commented 2 years ago

I believe it looks good, thank you very much :cat: