search

rdp / screen-capture-recorder-to-video-windows-free

a free open source windows "screen capture" device and recorder (also allows VLC/ffmpeg and others to capture/stream desktop/audio)
https://github.com/rdp/screen-capture-recorder-to-video-windows-free/releases
Other
2.09k stars 458 forks source link

Bundle JRE 8 and use it - fix for incompatibility with newer Java versions #132

Closed mvorisek closed 3 years ago

mvorisek commented 4 years ago

fixes https://github.com/rdp/screen-capture-recorder-to-video-windows-free/issues/96

notes:

rdp commented 4 years ago

Hmm it's tricky to include a bundled. I might take a patch that updates jruby though! :)

On Sun, Jun 7, 2020 at 3:18 AM Michael Voříšek notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/rdp/screen-capture-recorder-to-video-windows-free/pull/132 Commit Summary

  • Bundle Java 8 JRE
  • Update bat launcher to use bundled Java

File Changes

Patch Links:

- https://github.com/rdp/screen-capture-recorder-to-video-windows-free/pull/132.patch

https://github.com/rdp/screen-capture-recorder-to-video-windows-free/pull/132.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rdp/screen-capture-recorder-to-video-windows-free/pull/132, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADBUEWIIAH2JP5KFGOCXTRVNLPHANCNFSM4NXABO2Q .

mvorisek commented 3 years ago

Hmm it's tricky to include a bundled. I might take a patch that updates jruby though! :)

@rdp yes, I also prefer it, would you be so kind to look at it? It is actually quite urgent, as without Java 9+ support, it won't work for most of the users. Thanks.

rdp commented 3 years ago

Please test https://github.com/rdp/screen-capture-recorder-to-video-windows-free/releases/tag/v0.12.11 thanks!

mvorisek commented 3 years ago

Please test https://github.com/rdp/screen-capture-recorder-to-video-windows-free/releases/tag/v0.12.11 thanks!

I run Setup.Screen.Capturer.Recorder.v0.12.11.exe and the issue is gone - tested with Java 12. Many thanks, @rdp / Roger!

rdp commented 3 years ago

Thanks for the prods in the right direction :)

On 10/16/20, Michael Voříšek notifications@github.com wrote:

Closed #132.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/rdp/screen-capture-recorder-to-video-windows-free/pull/132#event-3888133028