rdp / screen-capture-recorder-to-video-windows-free

a free open source windows "screen capture" device and recorder (also allows VLC/ffmpeg and others to capture/stream desktop/audio)
https://github.com/rdp/screen-capture-recorder-to-video-windows-free/releases
Other
2.09k stars 458 forks source link

little suggestion and request. #41

Open mca64 opened 10 years ago

mca64 commented 10 years ago

hwnd_to_track works great but only for client window. Please add support for whole window (GetClientRect --> GetWindowRect). I suggest to overide values for start_x and start_y to 0 when hwnd_to_track is used. Spend some time with why this isnt work, when few months ago i could use it. Will be possible to add support for fast desktop capture on Windows 8? http://msdn.microsoft.com/en-us/library/windows/desktop/hh404487%28v=vs.85%29.aspx

I know OBS is using this there

Could you tell me more about this track_new_x_y_coords_each_frame_if_1 ? how it works? Thank You for good work!

rdp commented 10 years ago

Good idea. Doesn't it capture the whole window by default, or do you have to call out the size? What if they resize that window what should it do then, I guess just keep the initial size?

On Wed, Jul 30, 2014 at 5:01 AM, mca64 notifications@github.com wrote:

"hwnd_to_track" works great but only for client window. Please add support for whole window. I suggest to overide vaues for start_x and start_y to 0 when hwnd_to_track is used. Spend some time with why this isnt work, when few months ago i could use it. Will be possible to add support for fast desktop capture on Windows 8? http://msdn.microsoft.com/en-us/library/windows/desktop/hh404487%28v=vs.85%29.aspx

I know OBS is using this there

— Reply to this email directly or view it on GitHub https://github.com/rdp/screen-capture-recorder-to-video-windows-free/issues/41 .

mca64 commented 10 years ago

by default it captures client window. Cause when i set width and height for whole window on video i get client window + black bars. So i guess you use somewhere in code GetClientRect . This is good (for games etc), but please add the same thing with GetWindowRect for hwnd track (for egxample capture whole notepad with bars). So there will be possibility to choose

mca64 commented 10 years ago

https://github.com/rdp/screen-capture-recorder-to-video-windows-free/blob/469f0b66e8f7e7516cda72e879e78ca18f61ced9/source_code/PushSourceDesktop.cpp#L408

mca64 commented 10 years ago

"What if they resize that window what should it do then, I guess just keep the initial size?" Yes, keep it cause nothing to do when encoding already started. Good thing would be also somehow update hwnd, cause for egxample in Starcraft there will be diffrent hwnd for lobby and difrrent for a game. If i choose one hwnd then after a game will be black screen.

rdp commented 10 years ago

So basically, teh only real change is to set start_x and start_y to 0?

On Wed, Jul 30, 2014 at 12:32 PM, mca64 notifications@github.com wrote:

"What if they resize that window what should it do then, I guess just keep the initial size?" Yes, keep it cause nothing to do when encoding already started

— Reply to this email directly or view it on GitHub https://github.com/rdp/screen-capture-recorder-to-video-windows-free/issues/41#issuecomment-50659544 .

mca64 commented 10 years ago

for current version with hwnd track this must be set to 0 for me. For whole window i posted some changes right now. Cant check it but should work.