search

rdp / substruct

Automatically exported from code.google.com/p/substruct
0 stars 0 forks source link

store/product view partial isn't MVC #117

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This is a code refactoring

The store/product partial is not MVC, the display html is all embedded in a
helper.

(My graphic designer wasn't overly keen on trying to edit the helper function!)

Patch attached

Original issue reported on code.google.com by paul.g.m...@gmail.com on 15 Aug 2008 at 5:40

Attachments:

GoogleCodeExporter commented 9 years ago 
Good idea for a patch, bad execution.

Please test / debug your code before submitting in the future. Image path was 
wrong
and some variables not set correctly.

Could cause issues when upgrading, so making a note of this.

...Fixed in r124

Original comment by subim...@gmail.com on 16 Aug 2008 at 4:11

GoogleCodeExporter commented 9 years ago 
Urgh! Apologies, looks like I attached a duff file.

Original comment by paul.g.m...@gmail.com on 17 Aug 2008 at 12:14