rdp / substruct

Automatically exported from code.google.com/p/substruct
0 stars 0 forks source link

PATCH The system gives a wrong list of products accepting invalid tags in the front face site. (related with issue 96) #99

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Enter an URL that have an invalid tag at the address bar and a subtag
together. i.e.
http://localhost:3000/store/show_by_tags/valid/invalid
or
http://localhost:3000/store/show_by_tags/invalid/valid

What is the expected output? What do you see instead?
It should show a 404 page. It shows a product list using the invalid tag.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.10

Please provide any additional information below.
It was fixed wrong, I maintained the 404 behavior and put the render in the
right place, as sometimes the hash can contain a valid tag when an invalid
one was passed together. It has an unreable part too, the @tag_names var
will never evaluate to false as the tags param will be an empty hash when
no tag is passed.

Original issue reported on code.google.com by edmundo...@gmail.com on 17 Jun 2008 at 5:47

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, fixed in r110

Original comment by subim...@gmail.com on 11 Aug 2008 at 10:23