rdrop / exponent-server-sdk-elixir

Use to send push notifications to Exponent Experiences from an Elixir/Phoenix server.
MIT License
19 stars 15 forks source link

use local structs for data push #4

Open vinagrito opened 4 years ago

vinagrito commented 4 years ago

This is not a final version but it attempts to address the main issues found and it got spread to other areas as a result of the initial change

The push/1 & push_list/1 functions are not currently using the advantages of having a custom struct PushMessage. Even further, both methods are piping the incoming message/s map/s in order to cast them but at the end of each method the orinal passed arguments are sent to Expo. This just means that the incoming data could say anything because something else is being sent. And, also, lists are not being ckunked every 100, so it does't seem to be possible to send more than 100 push notifications

Again, this is not a final version but it may be a place to start the refactor @rdrop