search

rdumitriu / jira-rewards

JIRA Rewards Plugin - Remember your owned beers
Other
7 stars 1 forks source link

Reward is showing against all issues in a project #2

Closed RCheesley closed 10 years ago

RCheesley commented 10 years ago

I intended to offer a reward for one single issue but it is appearing against every issue in the project. Seems like it's tied to the project, not the issue.

I can't find any documentation so I'm not sure if this is a bug, or expected behaviour, but I would expect to be able to assign just to a single issue :)

rdumitriu commented 10 years ago

If I remember well, our purpose was to share the reward will anybody. Let's see if we deserve that nice review of yours ... :) Florin, could you comment on this please ?

RCheesley commented 10 years ago

Sure, but I might need one specific issue to be resolved urgently, so I would assign a reward to that issue - e.g. I'll give you 2 beers if you fix this before a specified date. Just for that issue, not for every issue in the project.

Perhaps there could be a differentiation between beers being offered in the whole project, and beers being offered for that specific issue you're looking at? Might be a way of making it clearer :)

fmanaila commented 10 years ago

Indeed, that was our intention, and the rewards do actually get bound to issues rather than the whole project ( see https://github.com/rdumitriu/jira-rewards/blob/master/src/main/java/ro/agrade/jira/rewards/ui/actions/IssueRewardAction.java#L69 where getId() is the issue id). The problem is that the rewards do not get filtered by their issue id when they are displayed ( should be filtered somewhere around here https://github.com/rdumitriu/jira-rewards/blob/master/src/main/java/ro/agrade/jira/rewards/context/IssueRewardsContextProvider.java#L71 ).

We'll fix this for the next version.

RCheesley commented 10 years ago

Hi folks,

I've had to delete the rewards, they were actually showing against every single project in our JIRA install, even customer-facing ones which was completely inappropriate given the content ^_-

Looking forward to a fix :)

Ruth

rdumitriu commented 10 years ago

You will have the fix on Monday (16/12). Sorry about the timing, we were caught in something else ...

fmanaila commented 10 years ago

Version 1.0.1 is now available on the Marketplace : https://marketplace.atlassian.com/plugins/ro.agrade.jira.rewards