rdvansloten / cert-manager-key-vault-sync

Kubernetes app that syncs cert-manager Secrets to Azure Key Vault.
MIT License
5 stars 0 forks source link

Helm Chart support for providing imagePullSecrets to pull from private image repositories. #8

Open jbmtalbot opened 4 days ago

jbmtalbot commented 4 days ago

Great project. It does one thing very well and is exactly what we needed to push certificates to Azure Key Vault for easy pulling with external-secrets.

For those of us required to pulling images from private repositories only, support for imagePullSecrets in the Helm Chart would be helpful. It could be implemented either in the ServiceAccount or Deployment and the user supplies the imagePullSecret as a Kubernetes secret in the same namespace.

Example

---
apiVersion: v1
kind: ServiceAccount
imagePullSecrets:
- name: <kubernetes-secret>
...
---
apiVersion: apps/v1
kind: Deployment
...
spec:
  template:
    spec:
      imagePullSecrets:
      - name: <kubernetes-secret>
...
rdvansloten commented 4 days ago

Great suggestion! Seems easy enough to implement. Will probably push it out somewhere this week 🙂