search

rdvdev2 / vanity-splash-text

Discover your mods through the splash texts!
https://modrinth.com/mod/vanity-splash-text
GNU Lesser General Public License v3.0
2 stars 1 forks source link

Fix Grammar #1

Closed sylv256 closed 2 years ago

sylv256 commented 2 years ago

it was really bothering me okay

sylv256 commented 2 years ago

We also may want to shorten the extraneous punctuation (e.g., "????" to "??").

Do Not Merge Yet!

rdvdev2 commented 2 years ago

Whoa, that one slipped through! Thanks for noticing.

We also may want to shorten the extraneous punctuation (e.g., "????" to "??").

The "????" is for emphasis, I like it as it is. Did you notice any other error, or do we merge?

sylv256 commented 2 years ago

Whoa, that one slipped through! Thanks for noticing.

We also may want to shorten the extraneous punctuation (e.g., "????" to "??").

The "????" is for emphasis, I like it as it is. Did you notice any other error, or do we merge?

I did find a few. I'll fix them right now.

sylv256 commented 2 years ago

(You may merge now)

rdvdev2 commented 2 years ago

Thanks for your contribution!

rdvdev2 commented 2 years ago

PS: Next time you draft a PR that you don't want to get merged yet, remember GitHub allows you to mark it as WIP.