search

rdw-archive / WebClient

[Proof of Concept] Browser-based client capable of rendering networked multiplayer games using modern web technologies
1 stars 0 forks source link

Streamline the C_Profiling API so that it can be properly disabled #140

Closed Duckwhale closed 2 years ago

Duckwhale commented 2 years ago

Currently it uses the console API directly, so it can't be disabled using the global Channels (logging) functionality. That is, setting Channels[Enum.LOG_LEVEL_PROFILE] = null has no effect, while it does work for all "regular" log levels.

This is a minor issue I noticed while running the test suite in "quiet" mode; profiling output is still displayed there when it probably shouldn't,

Duckwhale commented 2 years ago

This is kind of annoying with many tests relying on the decoders etc., which feature profiling. Bumping up its priority since it should be easy to fix.

Duckwhale commented 2 years ago

Looks like this is obsolete; profiling can already be disabled by using C_Settings.setValue("enableProfiling", false).

There's probably no benefit in redesigning the C_Profiling API to work more similarly to the logging system at this time.