search

re-actors / alls-green

A check for whether the dependency jobs are all green.
https://github.com/marketplace/actions/alls-green
BSD 3-Clause "New" or "Revised" License
110 stars 12 forks source link

Include "Cancelled" in Skipped Statuses #7

Closed tubbo closed 2 years ago

tubbo commented 2 years ago

Jobs can be cancelled externally, either manually or automatically with an action. Cancelled jobs fall into the "failure" state of this action, and since they are not explicit failures they should be considered as "skipped" in the same way that jobs which are automatically skipped are.

tubbo commented 2 years ago

@webknjaz We use this to prevent our publish job from running until all of the other jobs complete or are skipped, but that's basically just to prevent communicating a release update until the site is fully deployed. I guess we're using it differently than most others, since if a job is canceled then the publish job will be canceled as well. The problem was that this job considered canceled jobs to be failures, so we were getting a lot of spam in our notifications when the publish job "failed", but it was actually just being canceled and another future release was on its way, so this was an expected outcome. I don't feel like this is totally necessary for everyone, and hearing your reasoning on why this decision was made, it now makes a lot of sense why alls-green works this way out of the box. We're not using it to block a dangerous job from running until all others have passed, so I think I'll close this and we can continue using our fork for the time being.

webknjaz commented 2 years ago

FWIW, I'm totally open to having a separate input for this. It just needs to come with a fair warning in the README :)