[VEV-04C] Suboptimal Struct Declaration Style - Githubissues

re-al-Foundation / rwa-contracts

0 stars 0 forks source link

[VEV-04C] Suboptimal Struct Declaration Style #105

Closed chasebrownn closed 5 months ago

chasebrownn commented 5 months ago

VEV-04C: Suboptimal Struct Declaration Style

Type	Severity	Location
Code Style		VotingEscrowVesting.sol:L127

Description:

The linked declaration style of a struct is using index-based argument initialization.

Example:

vestingSchedules[tokenId] = VestingSchedule(startTime, endTime, amount);

Recommendation:

We advise the key-value declaration format to be utilized instead, greatly increasing the legibility of the codebase.

chasebrownn commented 5 months ago

Resolved