search

re-al-Foundation / rwa-contracts

Core dev environment for the RWA Governance contracts
0 stars 0 forks source link

[RRR-01S] Inexistent Event Emissions #12

Closed chasebrownn closed 7 months ago

chasebrownn commented 7 months ago

RRR-01S: Inexistent Event Emissions

Type Severity Location
Language Specific RealReceiver.sol:L115-L118, L124-L127

Description:

The linked functions adjust sensitive contract variables yet do not emit an event for it.

Example:

function setRwaToken(address _newRwaToken) external onlyOwner {
    require(_newRwaToken != address(0), "Cannot be address(0)");
    rwaToken = _newRwaToken;
}

Recommendation:

We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.

chasebrownn commented 7 months ago

Acknowledged