search

re-al-Foundation / rwa-contracts

0 stars 0 forks source link

[RDR-01S] Data Location Optimizations #14

Closed chasebrownn closed 6 months ago

chasebrownn commented 6 months ago

RDR-01S: Data Location Optimizations

Type Severity Location
Gas Optimization RevenueDistributor.sol:L182-L184

Description:

The linked input arguments are set as memory in external function(s).

Example:

function convertRewardTokenBatch(
    address[] memory _tokens,
    uint256[] memory _amounts,
    address[] memory _targets,
    bytes[] calldata _data
) external isDistributor returns (uint256[] memory _amountsOut) {

Recommendation:

We advise them to be set as calldata optimizing their read-access gas cost.

chasebrownn commented 6 months ago

Acknowledged