search

re-al-Foundation / rwa-contracts

0 stars 0 forks source link

[RDR-02S] Inexistent Event Emissions #15

Closed chasebrownn closed 6 months ago

chasebrownn commented 6 months ago

RDR-02S: Inexistent Event Emissions

Type Severity Location
Language Specific RevenueDistributor.sol:L236-L238, L245-L248, L299-L301

Description:

The linked functions adjust sensitive contract variables yet do not emit an event for it.

Example:

function setDistributor(address _distributor, bool _canDistribute) external onlyOwner {
    canDistribute[_distributor] = _canDistribute;
}

Recommendation:

We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.

chasebrownn commented 6 months ago

Acknowledged