[RDR-04S] Inexistent Sanitization of Input Addresses

[chasebrownn]

RDR-04S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		RevenueDistributor.sol:L118-L128

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

function initialize(
    address _admin,
    address _revStreamETH,
    address _veRwa
) external initializer {
    __Ownable_init(_admin);
    __UUPSUpgradeable_init();

    revStreamETH = RevenueStreamETH(payable(_revStreamETH));
    veRwaNFT = _veRwa;
}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.

[chasebrownn]

Resolved. Except for _revStreamETH since we have an external setter we can call post-initialize