[VEV-01S] Inexistent Event Emission - Githubissues

re-al-Foundation / rwa-contracts

0 stars 0 forks source link

[VEV-01S] Inexistent Event Emission #25

Closed chasebrownn closed 6 months ago

chasebrownn commented 6 months ago

VEV-01S: Inexistent Event Emission

Type	Severity	Location
Language Specific		VotingEscrowVesting.sol:L108-L110

Description:

The linked function adjusts a sensitive contract variable yet does not emit an event for it.

Example:

function setVotingEscrowContract(address _votingEscrow) external onlyOwner {
    votingEscrow = IVotingEscrow(_votingEscrow);
}

Recommendation:

We advise an event to be declared and correspondingly emitted to ensure off-chain processes can properly react to this system adjustment.

chasebrownn commented 6 months ago

Acknowledged