search

re-al-Foundation / rwa-contracts

Core dev environment for the RWA Governance contracts
0 stars 0 forks source link

[RDR-03S] Suboptimal Event Declaration #37

Closed chasebrownn closed 7 months ago

chasebrownn commented 7 months ago

RDR-03S: Suboptimal Event Declaration

Type Severity Location
Gas Optimization RevenueDistributor.sol:L96

Description:

The referenced event declaration does not have any indexed argument or have less than three indexed arguments that are a primitive type.

Example:

event ETHReceived(address sender, uint256 amount);

Recommendation:

Apart from aiding off-chain integrators in consuming and filtering such an event, primitive types that are set as indexed will result in a gas optimization due to reduced memory costs. As such, we advise the indexed keyword to be introduced to up to three different primitive types in total optimizing the referenced event declaration.