re-al-Foundation / rwa-contracts

0 stars 0 forks source link

[RHR-02S] Inexistent Event Emissions #42

Closed chasebrownn closed 6 months ago

chasebrownn commented 6 months ago

RHR-02S: Inexistent Event Emissions

Type Severity Location
Language Specific RoyaltyHandler.sol:L166-L168, L173-L175, L180-L182, L187-L189, L194-L196, L201-L203

Description:

The linked functions adjust sensitive contract variables yet do not emit an event for it.

Example:

function setALMBox(address _box) external onlyOwner {
    box = _box;
}

Recommendation:

We advise an event to be declared and correspondingly emitted for each function to ensure off-chain processes can properly react to this system adjustment.