re-al-Foundation / rwa-contracts

0 stars 0 forks source link

[VUE-01M] Potentially Improper Implementation #65

Closed chasebrownn closed 5 months ago

chasebrownn commented 5 months ago

VUE-01M: Potentially Improper Implementation

Type Severity Location
Code Style VotesUpgradeable.sol:L202

Description:

The referenced statement contains an in-line documentation statement that states it "was" VotesUpgradeable::_getVotingUnits(account) even though the statement remains the same as in the original implementation.

Impact:

Whether the documentation or the code should change is indefinite rendering this exhibit to be of unknown severity.

Example:

_moveDelegateVotes(oldDelegate, delegatee, _getVotingUnits(account)); // was _getVotingUnits(account)

Recommendation:

We advise this to be evaluated by the Re.al Foundation team and the code to either be updated or have its documentation rectified.

chasebrownn commented 5 months ago

Acknowledged