re-al-Foundation / rwa-contracts

0 stars 0 forks source link

[VEV-03M] Inexistent Conformity of EIP-6372 #68

Closed chasebrownn closed 5 months ago

chasebrownn commented 5 months ago

VEV-03M: Inexistent Conformity of EIP-6372

Type Severity Location
Standard Conformity VotingEscrowVesting.sol:L32

Description:

The RWAVotingEscrow contract that the VotingEscrowVesting contract integrates with supports the EIP-6372 standard, however, the VotingEscrowVesting contract itself does not.

Impact:

The VotingEscrowVesting contract may presently be integrated with a votingEscrow implementation that conforms to EIP-6372 albeit with a different clock style than block.timestamp.

Example:

contract VotingEscrowVesting is ReentrancyGuard, OwnableUpgradeable, UUPSUpgradeable {

Recommendation:

We advise the standard to be properly integrated and supported similarly to other vesting implementations within the ecosystem.

Additionally, we advise the VotingEscrowVesting::setVotingEscrowContract function to ensure that the IERC6372::CLOCK_MODE implementations between the contracts are identical.

chasebrownn commented 5 months ago

Resolved