[CCM-05C] Repetitive Value Literal - Githubissues

re-al-Foundation / rwa-contracts

0 stars 0 forks source link

[CCM-05C] Repetitive Value Literal #76

Closed chasebrownn closed 5 months ago

chasebrownn commented 5 months ago

CCM-05C: Repetitive Value Literal

Type	Severity	Location
Code Style		CrossChainMigrator.sol:L214, L288, L368

Description:

The linked value literal is repeated across the codebase multiple times.

Example:

amountTokens = lockedAmount + ((lockedAmount * (multiplier - 1e18)) / 1e18) - claimed;

Recommendation:

We advise it to be set to a constant variable instead optimizing the legibility of the codebase.

chasebrownn commented 5 months ago

Acknowledged