The referenced statements will interact with the veRwaNFT known implementation via low-level call operations rather than casting the veRwaNFT to an interface and invoking the methods that way.
Example:
(bool success,) = address(veRwaNFT).call(
abi.encodeWithSignature("migrateBatch(address,uint256[],uint256[])", to, amounts, durations)
);
if (!success) revert MigrationFailed(SEND_NFT_BATCH);
Recommendation:
We advise the code to declare a proper interface for the migration methods and for the RealReceiver to properly use it, optimizing its legibility greatly.
If graceful error handling is desired, the try-catch paradigm can be adopted to achieve the same in a highly legible manner.
chasebrownn
commented
5 months ago
RRR-01C: Improper Low-Level Interactions
Description:
The referenced statements will interact with the
veRwaNFTknown implementation via low-levelcalloperations rather than casting theveRwaNFTto aninterfaceand invoking the methods that way.Example:
Recommendation:
We advise the code to declare a proper
interfacefor the migration methods and for theRealReceiverto properly use it, optimizing its legibility greatly.If graceful error handling is desired, the try-catch paradigm can be adopted to achieve the same in a highly legible manner.