search

re-rxjs / react-rxjs

React bindings for RxJS
https://react-rxjs.org
MIT License
549 stars 19 forks source link

chore(shareLatest): simplify implementation #102

Closed josepot closed 4 years ago

josepot commented 4 years ago

I noticed this silly (and kinda superfluous) logic on shareLatest... It's a mistake that I made when I wrote the code for supporting error boundaries on suspense and I'm quite confident this is the correct code. It's difficult to come up with a breaking test, because AFAIK the previous code didn't trigger any issues.

codecov[bot] commented 4 years ago

Codecov Report

Merging #102 into main will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          373       371    -2     
  Branches        42        41    -1     
=========================================
- Hits           373       371    -2
Impacted Files Coverage Δ
packages/core/src/internal/share-latest.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8069ef2...7e6acc1. Read the comment docs.