search

re-rxjs / react-rxjs

React bindings for RxJS
https://react-rxjs.org
MIT License
553 stars 20 forks source link

fix(core): factory react observable #136

Closed josepot closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #136 into main will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #136   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          371       374    +3     
  Branches        42        42           
=========================================
+ Hits           371       374    +3
Impacted Files Coverage Δ
packages/core/src/bind/connectFactoryObservable.ts 100.00% <100.00%> (ø)
packages/core/src/internal/useObservable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 266d597...e89b1c8. Read the comment docs.

josepot commented 4 years ago

Would it be posible to have some tests that reproduce the fixed issue?

I'm not sure how to do that without testing an implementation detail... I'm open to suggestions, though. :sweat_smile: