search

re-rxjs / react-rxjs

React bindings for RxJS
https://react-rxjs.org
MIT License
553 stars 20 forks source link

fix(core/bind): resulting observable of bind should emit the default … #149

Closed josepot closed 3 years ago

josepot commented 3 years ago

…value if provided

I really think that we should consider this a bug-fix, although someone could argue that it's a breaking change... @voliva what do you think?

codecov[bot] commented 3 years ago

Codecov Report

Merging #149 (a9afad6) into main (69d2f66) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          349       350    +1     
  Branches        43        44    +1     
=========================================
+ Hits           349       350    +1
Impacted Files Coverage Δ
packages/core/src/bind/connectFactoryObservable.ts 100.00% <100.00%> (ø)
packages/core/src/bind/connectObservable.ts 100.00% <100.00%> (ø)
packages/core/src/internal/share-latest.ts 100.00% <100.00%> (ø)
packages/core/src/internal/useObservable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69d2f66...a9afad6. Read the comment docs.