search

re-rxjs / react-rxjs

React bindings for RxJS
https://react-rxjs.org
MIT License
549 stars 19 forks source link

feat(core): factory `bind` accept function for default value #183

Closed josepot closed 3 years ago

josepot commented 3 years ago

I've been meaning to make this improvement for a while now, but I never got to it... Technically speaking, this is a breaking change. Because in the super-rare event that someone was using a factory bind with Observables of functions and that the default-value overload was being used, then they will have to wrap that default function into another function... So, yeah, this should go into 0.7.0 I guess :shrug:

@voliva what do you think?

codecov[bot] commented 3 years ago

Codecov Report

Merging #183 (e0d8cc8) into main (961eade) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head e0d8cc8 differs from pull request most recent head 02f286a. Consider uploading reports for the commit 02f286a to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##              main      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          431       434    +3     
  Branches        54        55    +1     
=========================================
+ Hits           431       434    +3
Impacted Files Coverage Δ
packages/core/src/bind/index.ts 100.00% <ø> (ø)
packages/core/src/bind/connectFactoryObservable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 961eade...02f286a. Read the comment docs.