search

re-rxjs / react-rxjs

React bindings for RxJS
https://react-rxjs.org
MIT License
549 stars 19 forks source link

feat(core): 🎉 Remove source$ prop from Subscribe 🎉 #191

Closed josepot closed 3 years ago

josepot commented 3 years ago

I won't be able to sleep tonight because of this... With this change I finally feel like we are ready for v1.0.0! :tada:

codecov[bot] commented 3 years ago

Codecov Report

Merging #191 (ae4b4bd) into main (f8afe0c) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        28    +1     
  Lines          429       432    +3     
  Branches        55        54    -1     
=========================================
+ Hits           429       432    +3
Impacted Files Coverage Δ
packages/core/src/Subscribe.tsx 100.00% <100.00%> (ø)
packages/core/src/internal/MissingSubscription.ts 100.00% <100.00%> (ø)
packages/core/src/internal/share-latest.ts 100.00% <100.00%> (ø)
packages/core/src/internal/useObservable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8afe0c...ae4b4bd. Read the comment docs.

josepot commented 3 years ago

Closing this in favor of #192