codecov[bot]
commented
2 years ago Codecov Report
Merging #238 (0619f1f) into main (b84fd55) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## main #238 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 409 317 -92
Branches 59 40 -19
=========================================
- Hits 409 317 -92 | Impacted Files | Coverage Δ | |
|---|---|---|
| packages/core/src/SUSPENSE.ts | 100.00% <100.00%> (ø) |
|
| packages/core/src/Subscribe.tsx | 100.00% <100.00%> (ø) |
|
| packages/core/src/bind/connectFactoryObservable.ts | 100.00% <100.00%> (ø) |
|
| packages/core/src/bind/connectObservable.ts | 100.00% <100.00%> (ø) |
|
| packages/core/src/bind/index.ts | 100.00% <100.00%> (ø) |
|
| packages/core/src/internal/useObservable.ts | 100.00% <100.00%> (ø) |
|
| packages/core/src/shareLatest.ts | 100.00% <100.00%> (ø) |
|
| packages/core/src/useStateObservable.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update b84fd55...0619f1f. Read the comment docs.
We finally got a proper integration with
rxjs-statewhich works with both React 17 and React 18, and that it's also backwards compatible with v0.8.x :tada: I really think that this is what version 1 is going to look like. Although, let's first publish v0.9.0, b/c I'm not 100% sold on whether we should keepSUSPENSEin its current form.I've put @voliva as a co-author of this commit b/c this really has been a joined effort.
What's this change is about:
@react-rxjs/corebecomes a superset of@josepot/rxjs-state(which hopefully in the near future will be under@rxjs-state/core:crossed_fingers:)useStateObservablehook, which can be used for consuming theStateObservables that come fromrxjs-state` :tada:shareLatestfor backwards compatible reasons. However, now it's just a wrapper on RxJSshare, which is why the rxjs peer-dependency range has changed.