search

re-rxjs / react-rxjs

React bindings for RxJS
https://react-rxjs.org
MIT License
546 stars 18 forks source link

fix: useStateObservable #253

Closed josepot closed 2 years ago

josepot commented 2 years ago

useStateObservable was not taking into account the Context subscription :see_no_evil:

codecov[bot] commented 2 years ago

Codecov Report

Merging #253 (bb2c359) into main (6fe91f8) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          370       361    -9     
  Branches        52        50    -2     
=========================================
- Hits           370       361    -9
Impacted Files Coverage Δ
packages/core/src/Subscribe.tsx 100.00% <100.00%> (ø)
packages/core/src/bind/connectFactoryObservable.ts 100.00% <100.00%> (ø)
packages/core/src/bind/connectObservable.ts 100.00% <100.00%> (ø)
packages/core/src/useStateObservable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fe91f8...bb2c359. Read the comment docs.