re-rxjs / react-rxjs

React bindings for RxJS
https://react-rxjs.org
MIT License
550 stars 19 forks source link

fix: Subscribe with async errors #273

Closed josepot closed 2 years ago

josepot commented 2 years ago

This PR adds a new test, which is currently failing on the main branch, and its corresponding fix.

codecov[bot] commented 2 years ago

Codecov Report

Merging #273 (fe8aef1) into main (b5826b4) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          362       363    +1     
  Branches        50        49    -1     
=========================================
+ Hits           362       363    +1     
Impacted Files Coverage Δ
packages/core/src/Subscribe.tsx 100.00% <100.00%> (ø)
packages/core/src/useStateObservable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5826b4...fe8aef1. Read the comment docs.