search

re-rxjs / react-rxjs

React bindings for RxJS
https://react-rxjs.org
MIT License
550 stars 19 forks source link

Use native react use-sync-external-store instead of package #295

Closed mbret closed 1 year ago

mbret commented 1 year ago

possibly reducing package size

josepot commented 1 year ago

As stated in the peerDependencies section of its package.json, the current version of @react-rxjs/core is intended to work with react >=16.8.0.

Does that mean that because of that users of React >18 will end up having a larger bundle size on their production built?

Not at all. I'm using React 18 in a couple of projects myself and my production built doesn't include the code for the shim. The reason being that most bundlers are able to tree-shake this code. I mean, perhaps there are some bundlers which in some situations are not able to tree-shake that code. I would be a bit surprised about that, but I guess that's possible. Are you running into that issue? Does your production built include the code for the shim? If that's the case: could you please share a link of a project/repo that has that issue? :pray:

It's possible that in the future we will end up dropping support for versions prior to React 18, in which case we will stop using the official use-sync-external-store package provided by the React core team. However, we don't see the need for that at the moment.

mbret commented 1 year ago

Clear answer, thank you

Are you running into that issue?

I haven't checked