reHackable / maxio

Companion daemon for the reMarkableā„¢ paper tablet
GNU Lesser General Public License v3.0
156 stars 53 forks source link

Notebook export shifts drawing with respect to background #11

Open m-weigand opened 6 years ago

m-weigand commented 6 years ago

Just tested the exportNotebook function. At this point the drawing layer is shifted with respect to the background (see attached figures).

Note that this does not happen with the rM2svg version developed here:

https://github.com/phil777/maxio/tree/master/tools

I see that this approach requires far more (or heavy?) dependencies (poppler, cairo). So I propose to add both versions of rM2svg to the repository and let the user switch (perhaps based on a dependency check?). Would you be willing to merge something like that?

Work-progress-work can be found here:

https://github.com/m-weigand/maxio/tree/svgCairo

Test output using rM2svg_cairo:

cairo.pdf

Test output using rM2svg in this repository:

convert.pdf

edupont commented 6 years ago

Yes, sounds sensible. Dependencies check is meaningful anyway.

trou commented 6 years ago

note that @phil777's approach is not perfect either and pull request #12 does not fix the problems.

Unfortunately, I can't spend more time debugging this.

florian-wagner commented 6 years ago

@trou Could you explain in more detail, which problems remain after #12?

trou commented 6 years ago

See the following files:

As you can see in dot-paper-master.pdf, the absolute position of the drawings looks correct, the text is right on the margin. However, the lines are supposed to be on dots, as seen on @phil777 version, which looses the text on the right.