shumy
commented
8 years ago I have many doubts about the usefulness of the Massage Factory. We can use methods to build messages that conform with the schema, but we still have a problem to validate the received messages! I have different and simpler suggestion to build this. We can have a method, something like validate(schema: JsonSchema, obj: Json): [throw error if failed] and use it like:
//in a config file
Validator.debug = true;
//if Validator.debug === false -> don't load
Validator.loadSchema(<message-schema-url>);
//normal use........................................................
let msg = {
from: x, to: y,
body: { ... }
}
//throw error if validation fails, if Validator.debug === false -> does nothing
Validator.validate(<message-schema-url>, msg);It's a simple implementation that has the following advantages:
- No hard dependency on a complex API
- It's able to validate created and received messages
- Validate other structures, not just messages, without a need to add another method
- Schemas should be static and stable in production, disable the overhead of schema validation. This will be very important for the ShyncherManager, I can't validate every change of the SyncObject in production, it will be overkill.
acheambe
emmelmann-fokus
pchainho
On our last telco for the Service Framework, was a proposal for an agile procedure of working between specification from WP2 and implementation on WP3.
In other words to have the option to automate the changes carried out on JSON schemas to be reflected on implementations without huge efforts.
Mechanisms for this needs to be investigated and it is not exactly clear at what point this should be done. Any proposals?