reTHINK-project / dev-msg-node-vertx

Apache License 2.0
0 stars 2 forks source link

msg-node-vertex adaptation for runtime-nodejs needed #20

Open jboulmal opened 8 years ago

jboulmal commented 8 years ago

Hello, While loading the SourceCode of this msg-node, we have found that it's using WebSocket which is not native in Nodejs :

null:208
          _this._sock = new WebSocket(_this._config.url);
                            ^
ReferenceError: WebSocket is not defined
    at VertxProtoStub._open (null:208:29)
    at e._callback (null:49:13)
    at /home/jamal/Desktop/Test_Remote_Proto/dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:783:17
    at Array.forEach (native)
    at t.value (/home/jamal/Desktop/Test_Remote_Proto/dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:782:15)
    at t.value (/home/jamal/Desktop/Test_Remote_Proto/dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:780:56)
    at t.value (/home/jamal/Desktop/Test_Remote_Proto/dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:841:129)
    at process.<anonymous> (/home/jamal/Desktop/Test_Remote_Proto/dev-runtime-nodejs/dist/ContextServiceProvider.js:53:19)
    at emitTwo (events.js:106:13)
    at process.emit (events.js:191:7)
Address Reason:  Response timeout!
Something failed on the deploy hyperty:  Response timeout!

We believe a small fix is needed on _this._sock = new WebSocket(_this._config.url);. May be including import WebSocket from 'ws' could solve this issue !

jboulmal commented 8 years ago

We are using temporarily fix for now. We need stable solution for the following errors :

null:245
          _this._sock = new SockJS(_this._config.url);
                            ^
ReferenceError: SockJS is not defined
    at VertxProtoStub._open (null:245:29)
    at e._callback (null:81:13)
    at ~/dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:783:17
    at Array.forEach (native)
    at t.value (~dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:782:15)
    at t.value (~/dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:780:56)
    at t.value (~dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:841:129)
    at process.<anonymous> (~/dev-runtime-nodejs/dist/ContextServiceProvider.js:49:20)
    at emitTwo (events.js:106:13)
    at process.emit (events.js:191:7)

and this :

null:208
          _this._sock = new WebSocket(_this._config.url);
                            ^
ReferenceError: WebSocket is not defined
    at VertxProtoStub._open (null:208:29)
    at e._callback (null:49:13)
    at ~/dist/runtime-core/dist/minibus.js:783:17
    at Array.forEach (native)
    at t.value (~/dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:782:15)
    at t.value (~/dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:780:56)
    at t.value (~/dev-runtime-nodejs/dist/runtime-core/dist/minibus.js:841:129)
    at process.<anonymous> (~/dev-runtime-nodejs/dist/ContextServiceProvider.js:53:19)
    at emitTwo (events.js:106:13)
    at process.emit (events.js:191:7)
Address Reason:  Response timeout!
Something failed on the deploy hyperty:  Response timeout!