search

reTHINK-project / dev-msg-node-vertx

Apache License 2.0
0 stars 2 forks source link

Registry Connector 0.8.0 and 0.8.1 version #39

Closed luistduarte closed 7 years ago

luistduarte commented 7 years ago

After this merge we got this error using docker-hub image. screenshot from 2017-03-21 12 01 27 You should check if nashorn is compatible with your code...

nunofmn commented 7 years ago

Here is working fine, and I tested it before submitting the pull request.

When deploying in docker is the MSG_NODE_CONFIG environment variable defined to prod? I didn't define the newest fields in the prod settings in node.config.json since I was not sure if TLS/SSL support was wanted by default

luistduarte commented 7 years ago

When we use MSG_NODE_CONFIG=env, there is not environment variables available on documentation available for configure registry.ssl.enabled and registry.retries, So I added both and I made some changes to deal with it. I added both env variables on README.md

When we set registry.ssl.enabled=true, we got an error.. Can you check it?

pchainho commented 7 years ago

@nunofmn pls update your docs when required and warn your "clients" about these changes

nunofmn commented 7 years ago

@pchainho I updated the connector docs some weeks ago with the release 0.8.0, in Domain Registry repository and added a section in this repository README here.

@luistduarte to enable SSL/TLS is necessary to create a set of certificates. In Registry Connector configuration section in this repository README there is a link for the instructions of how to configure.

luistduarte commented 7 years ago

I created the set of certificates and i set it up on registry config.. how can i test if its working correctly?

nunofmn commented 7 years ago

If the msg-node is able to communicate with the Domain Registry, and the DR is deployed with SSL/TLS enabled (with or without load balancer), it should be ok.

luistduarte commented 7 years ago

@nunofmn i got a question for you, registry-domain server will use this certificates, or is just for registry-domain connector of vertx?

nunofmn commented 7 years ago

The Domain Registry also need a certificate. If you also deploy the load balancer you will need also another certificate. More details in Domain Registry Manual