search

reTHINK-project / dev-msg-node-vertx

Apache License 2.0
0 stars 2 forks source link

Vertx MN domain registration issues #53

Closed sdruesedow closed 7 years ago

sdruesedow commented 7 years ago

The Vertx MN contradicts with the spec for domain registration messages in two points:

  1. The "from" field of messages sent to the MN for the domain registry is specified to start with "hyperty-runtime://" (see registration-messages.md ) The Vertx MN instead only works for "from" fields starting with "runtime://" and throws a NullPointerException otherwise.

    msg-node-vertx-local | 2017-06-07 10:17:53 INFO  BROKER - IN: (id: 1, type: open, from: hyperty-runtime://localhost/1, to: mn:/session)
msg-node-vertx-local | 2017-06-07 10:17:53 INFO  BROKER - RESOLVED: hyperty-runtime://localhost/1 - TO null
msg-node-vertx-local | T-HYPERTY: hyperty-runtime://localhost/1
msg-node-vertx-local | java.lang.NullPointerException
msg-node-vertx-local |  at eu.rethink.mn.pipeline.handlers.TransitionPipeHandler.handle(TransitionPipeHandler.java:45)
msg-node-vertx-local |  at eu.rethink.mn.pipeline.handlers.TransitionPipeHandler.handle(TransitionPipeHandler.java:33)
msg-node-vertx-local |  at eu.rethink.mn.pipeline.PipeContext.next(PipeContext.java:172)
msg-node-vertx-local |  at eu.rethink.mn.pipeline.handlers.ValidatorPipeHandler.handle(ValidatorPipeHandler.java:63)
msg-node-vertx-local |  at eu.rethink.mn.pipeline.handlers.ValidatorPipeHandler.handle(ValidatorPipeHandler.java:35)
msg-node-vertx-local |  at eu.rethink.mn.pipeline.PipeContext.next(PipeContext.java:172)
msg-node-vertx-local |  at eu.rethink.mn.pipeline.Pipeline.process(Pipeline.java:45)
...

  2. The Vertx MN only works if the "to" field of registration messages ends with a "/", e.g.:

    domain://registry.localhost/

    instead of 

    domain://registry.localhost

    otherwise it does not return responses and the testcases fail.

pchainho commented 7 years ago

@luistduarte can you have a look on this pls?

sdruesedow commented 7 years ago

any updates?

sdruesedow commented 7 years ago

I'm documenting the situation for D6.4 as it is

emmelmann-fokus commented 7 years ago

Hi,

From WP-6 perspective, I am fine with this as we have to only assess the work in WP-6 and provide feedback to the technical WPs.

But from an overall perspective, this will raise issues in the final review, i.e.,

Just my two cents.

luistduarte commented 7 years ago

Sorry for the delay. I did a fix on vertx branch develop, now it works with domain://registry.localhost

sdruesedow commented 7 years ago

I tested the latest develop version. The issue with the trailing "/" is solved, the other one remains. There are still NullPointerExceptions if the "from" field starts with "hyperty-runtime://".

luistduarte commented 7 years ago

it is fixed now.

sdruesedow commented 7 years ago

confirmed for develop branch --> closing