reTHINK-project / dev-service-framework

DEPRECATED! Service framework libs have been moved to dev-runtime-core repo
Apache License 2.0
1 stars 2 forks source link

Find a specific hyperty per schema and user #44

Closed vitormsilva closed 8 years ago

vitormsilva commented 8 years ago

When i try to get an specific hyperty like chat, i invoke advancedSearchPerHyperty(user, schema, resources, domain) we should have and array of hyperties, but only have this message result;

screenshot from 2016-05-27 11-29-35

vitormsilva commented 8 years ago

This issue was partial solved because I'm using an old version of msg-node-vertx and domain-registry, I update and got the correct answer.

But I have one more doubt, the user parameter, need to be like user://gmail.com/openidtest10 or should be and email like openidtest10@gmail.com?

gamdias commented 8 years ago

But I have one more doubt, the user parameter, need to be like user://gmail.com/openidtest10 or should be and email like openidtest10@gmail.com?

Added the support of both userURL and user email options. Any problem, please report.

vitormsilva commented 8 years ago

The method has changed.. now is discoveryHyperty, and it works.

My doubt now is related with registerHyperty resources, now is hard coded, you can fix this? Because when I look for scheme in this discoveryHyperty, as all are registered with the same resource it returns all hyperties and I can't distinguish each one;

if you need help, i can try to help you..

gamdias commented 8 years ago

About the resourcesFake/dataSchemesFake, they were created until I get the right information about the resources and schemas.

I think that some changes are needed so that I can access that information, and either are passed in the hyperty descriptor or the method registerHyperty is changed to support this information in the params received. Example: registerHyperty(sandbox, descriptor, resources, schema)

pchainho commented 8 years ago

In order to fix this issue the following tasks are required:

1- pass the runtime catalogue in the runtime registry constructor -> @vitormsilva

2- registry.registerHyperty(sandbox, descriptor) : query the runtime catalogue about hyperty descriptors and supported data object schemas, collect data from them e embed them in the registration message body -> @gamdias

3- complete demos descriptors to be used in the tests -> @vitormsilva

4- correct hypertyDiscovery, removed hardcoded results, and appropriately query the domain registry about active Hyperties -> @gamdias

vitormsilva commented 8 years ago

From my side:

1- pass the runtime catalogue in the runtime registry constructor: done 3- complete demos descriptors to be used in the tests: done

If something is not right, let me know

gamdias commented 8 years ago

I've updated the runtime registry to receive the schemas and resources from the catalogue.

Step 1 is done, step 4 is also done. The last thing missing is registry.unregisterAll() from this issue https://github.com/reTHINK-project/dev-runtime-core/issues/89

Please test to see if it's alright.

vitormsilva commented 8 years ago

Seems resolved. Closing;